Change STORAGE_DRIVERS to STORAGE_DRIVER_LIST to prevent conflicts

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

Change STORAGE_DRIVERS to STORAGE_DRIVER_LIST to prevent conflicts #217

Closed rhatdan closed 7 years ago

rhatdan commented 7 years ago

We use STORAGE_DRIVER passed in by the user, and STORAGE_DRIVERS intenally, this change makes it more difficult to accidently break contaner-storage-setup.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

rhatdan commented 7 years ago

One other idea would be to prefix all STORAGE* with an .

_STORAGE_DRIVERS _STORAGE_IN_FILE _STORAGE_OUT_FILE

rhatdan commented 7 years ago

This would make https://github.com/projectatomic/container-storage-setup/pull/217 less likely to happen

rhvgoyal commented 7 years ago

@rhatdan can you please have a look at #218 and see how does that look.

rh-atomic-bot commented 7 years ago

:umbrella: The latest upstream changes (presumably 2a074ca) made this pull request unmergeable. Please resolve the merge conflicts.

rhvgoyal commented 7 years ago

This is not needed any more with the merge of PR #220