search

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

Prefix internal global variables with underscore #220

Closed rhvgoyal closed 7 years ago

rhvgoyal commented 7 years ago

This will help differentiate between variables which are internal and should not be overridden using container-storage-setup file and the one which are overriddable.

Signed-off-by: Vivek Goyal vgoyal@redhat.com

rhvgoyal commented 7 years ago

@rhatdan PTAL

rhatdan commented 7 years ago

LGTM

rhvgoyal commented 7 years ago

@rh-atomic-bot r+ b2786ad

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit b2786ad with merge 2a074ca...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhvgoyal Pushing 2a074cac0fae921271ec74666987a1ee4fcf375b to master...