projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

Do docker metadata checks only in docker compatibility mode #223

Closed rhvgoyal closed 7 years ago

rhvgoyal commented 7 years ago

We don't want to be checking for existing /var/lib/docker/metadata/ dir for cases where inputfile and outputfile has been specified.

Signed-off-by: Vivek Goyal vgoyal@redhat.com

rhvgoyal commented 7 years ago

@rhatdan PTAL

rhatdan commented 7 years ago

Should we wait for @shishir-a412ed patch to just check if STORAGE_CONFIG="docker"?

That way user could specify /etc/sysconfig/docker-storage-setup with STORAGE_CONFIG="docker"

rhatdan commented 7 years ago

Fine LGTM

rhvgoyal commented 7 years ago

@rh-atomic-bot r+ 16334a1

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit 16334a1 with merge c13f873...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhvgoyal Pushing c13f873137b12ac9146a83d615cea927ead301e5 to master...