search

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

Redesigned container storage setup #239

Closed rhvgoyal closed 7 years ago

rhvgoyal commented 7 years ago

These are patches for new container-storage-setup design.

This gets rid of recently introduced mode of user specified INPUTFILE. Newly introduced commands should be used instead.

Old mode (comaptibility mode) will continue to work as it is. This mode assumes inputfile to be /etc/sysconfig/docker-storage-setup and output file as /etc/sysconfig/docker-storage.

rhvgoyal commented 7 years ago

@rhatdan PTAL.

rhvgoyal commented 7 years ago

@shishir-a412ed PTAL

rhvgoyal commented 7 years ago

@rhatdan, don't merge it yet. I am working on some fixes. Pushed patches early to get some feedback.

rhvgoyal commented 7 years ago

Fixed couple of issues and pushed patches again.

rhatdan commented 7 years ago

Need updated README.md file but we can do this in a different pull request.

rhvgoyal commented 7 years ago

@rhatdan Took care of your comments on man page. PTAL.

Also rebased on top of latest. Renamed my tests as shishir had introduced tests with similar numbers. Also renamed some of the functions.

rhvgoyal commented 7 years ago

@TomSweeneyRedHat I have taken care of your comments and pushed new patches. PTAL.

rhvgoyal commented 7 years ago

@rhatdan PTAL

rhatdan commented 7 years ago

@rh-atomic-bot r+ f195fc7

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit f195fc7 with merge 32ec977...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhatdan Pushing 32ec977c1769d46d4157ca3e54eea2009eef2bc1 to master...