Use profile_dir setting used by LVM2 during command execution

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

Use profile_dir setting used by LVM2 during command execution #241

Closed blocksmither closed 7 years ago

blocksmither commented 7 years ago

Use profile_dir setting used by LVM2 during command execution

"lvm dumpconfig" is currently used to determine profile_dir location. But if profile_dir is not explicitly defined in /etc/lvm/lvm.conf, then the default value used by lvm will not be listed. Hence use "lvm dumpconfig --type full" instead.

Signed-off-by: Carson Blake Smith smith.carson19@gmail.com

rh-atomic-bot commented 7 years ago

Can one of the admins verify this patch? I understand the following commands:

bot, add author to whitelist
bot, test pull request
bot, test pull request once

rhvgoyal commented 7 years ago

Can you make commit message a little cleaner. Something like.

Currently we use "lvm dumpconfing" to determine profile_dir location. But if profile_dir is not mentioned in /etc/lvm/lvm.conf, then default value used by lvm will not be listed. Hence use "lvm dumpconfig --type full" instead

rhvgoyal commented 7 years ago

Also please put a "Signed-off-by" message in the commit.

blocksmither commented 7 years ago

Sure. Although mine was clear, I spent a lot of text over-justifying.

Will go for something like your concise message, with a little cleanup. Also amending with my signoff as well.

rhvgoyal commented 7 years ago

LGTM

rhvgoyal commented 7 years ago

@rh-atomic-bot r+ b847fe3

rh-atomic-bot commented 7 years ago

:hourglass: Testing commit b847fe3 with merge 91a902d...

rh-atomic-bot commented 7 years ago

:sunny: Test successful - status-redhatci Approved by: rhvgoyal Pushing 91a902ddf82b2450f12dc6b8f635fdd249a05ab0 to master...