projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

Do not hardcode 'parted' path #244

Closed xdrus closed 6 years ago

xdrus commented 7 years ago

sfdisk failed on some disk, so I would prefer to use parted. However, it is not always installed to /usr/sbin (for example Amazon Linus install it /sbin).

rh-atomic-bot commented 7 years ago

Can one of the admins verify this patch? I understand the following commands:

rhatdan commented 7 years ago

bot, add author to whitelist

rhatdan commented 7 years ago

LGTM @rhvgoyal PTAL

rh-atomic-bot commented 6 years ago

:umbrella: The latest upstream changes (presumably 1b819de) made this pull request unmergeable. Please resolve the merge conflicts.

rhvgoyal commented 6 years ago

Did not get any response to my comments. Closing it. Once somebody cares enough, reopen with updated patch.