add MAX_DATA_SIZE option

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

add MAX_DATA_SIZE option #248

Closed jason-liew closed 7 years ago

jason-liew commented 7 years ago

Some sever have a large disk like 2T, but only need at most 200G for docker to store images and containers. And then create logical volume with rest free space as host path volume to be used with -v option in docker run command . Add new MAX_DATA_SIZE option may be simpler than calculating DATA_SIZE for every SERVER.

rh-atomic-bot commented 7 years ago

Can one of the admins verify this patch? I understand the following commands:

bot, add author to whitelist
bot, test pull request
bot, test pull request once

rhatdan commented 7 years ago

bot, add author to whitelist

rhatdan commented 7 years ago

LGTM @rhvgoyal PTAL

rhvgoyal commented 7 years ago

I don't think this is required.

First of all, we don't consume all the free space. We use 40% of free space and leave rest for others to use.
If you are worried that disk is too big and even 40% is a lot, then you can reduce that percentage by reducing DATA_SIZE=20%.

So DATA_SIZE is already doing what you need. Just that its in terms of percentage and not an absolute number.

rh-atomic-bot commented 7 years ago

:umbrella: The latest upstream changes (presumably eefd842) made this pull request unmergeable. Please resolve the merge conflicts.

rhatdan commented 7 years ago

Going to close this thanks to @rhvgoyal feedback