search

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems
Apache License 2.0
153 stars 77 forks source link

fstype is checked at wrong folder lever #280

Open NickJH opened 5 years ago

NickJH commented 5 years ago

When container-storage-setup is run it fails with: ERROR: XFS filesystem at /var has ftype=0, cannot use overlay backend; consider different driver or separate volume or OS reprovision

The message is correct insomuch that /var is on a partition with ftype=0, but I have mounted /var/lib/docker from a partition which has ftype=1 which allows docker to start without the ftype warnings. Shouldn't container-storage-setup also be using /var/lib/docker and not /var when testing for ftype?

rhvgoyal commented 5 years ago

I guess we could. /var/lib/docker is not present when run for the first time. We could improve it to first check for /var/lib/docker otherwise fall back to check on /var.

NickJH commented 5 years ago

That sounds like a plan.

Would it be better to test /var/lib before testing /var as it is conceivable that it could be being mounted from a different filesystem than /var. Is there any risk of /var/lib not existing on a system?