Fixes #282 use requiredby to make a hard dependency chain

projectatomic / container-storage-setup

Service to set up storage for Docker and other container systems

Apache License 2.0

153 stars 77 forks source link

Fixes #282 use requiredby to make a hard dependency chain #283

Open Klaas- opened 5 years ago

Klaas- commented 5 years ago

Fixes #282 use requiredby to make a hard dependency chain

rh-atomic-bot commented 5 years ago

Can one of the admins verify this patch? I understand the following commands:

bot, add author to whitelist
bot, test pull request
bot, test pull request once

rhatdan commented 5 years ago

@rhvgoyal PTAL As I recall we wanted to allow this to fail in order to allow Docker running with Devicemapper on loopback devices to work. I think containers-storage-setup would fail in that situation and cause Docker to use loopback devices. Now that we default to using Overlay, we could perhaps make the switch.

Klaas- commented 5 years ago

So there is a situation where you expect the service to fail? Wouldn't it be better/easier to just not use the service ie when dm on loopback "systemctl disable docker-storage-setup"? or even fully remove the package and only install it when needed?