search

projectatomic / docker

Docker - the open-source application container engine
http://www.docker.com
Apache License 2.0
81 stars 58 forks source link

Adjust Audit init in 1.12.6 to match 1.13.1 #295

Closed TomSweeneyRedHat closed 6 years ago

TomSweeneyRedHat commented 6 years ago

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com - What I did

While working on #293 I noted that the dockerd/daemon.go code in 1-13.1-rhel initialized the audit logging code in a similar manner to my fix in #292. This change brings the code in 1-12.6 in line with 1-13.1 which primarily adds a warning in a comment about the order of initialization for audit log.

- How I did it vi is my friend, and lots of testing.

- How to verify it There should be no discernible run time changes, the code works the same, it's just a little better ordered and commented in the code for future code maintenance.

- Description for the changelog Adjust internal ordering of audit logging.

This is part of the series of fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1496176

TomSweeneyRedHat commented 6 years ago

@jwhonce @rhatdan @runcom PTAL

rhatdan commented 6 years ago

I am not sure we are still shipping this?

TomSweeneyRedHat commented 6 years ago

I'm not sure if this version will still ship or not. The BZ raised this issue in this version so I decided to make the minor adjustment.

TomSweeneyRedHat commented 6 years ago

@rhatdan @runcom Can this be merged? If not, please let me know what (if anything) I can do. This will address https://bugzilla.redhat.com/show_bug.cgi?id=1496176 which is on the 7.5 blocker list.

rhatdan commented 6 years ago

Yes.