search

projectatomic / docker

Docker - the open-source application container engine
http://www.docker.com
Apache License 2.0
81 stars 58 forks source link

Fix stderr logging for journald and syslog #345

Closed robbmanes closed 5 years ago

robbmanes commented 5 years ago

logger.PutMessage, added in #28762 (v17.04.0-ce), clears msg.Source. So journald and syslog were treating stderr messages as if they were stdout.

Signed-off-by: David Glasser glasser@davidglasser.net

- What I did Backported https://github.com/moby/moby/pull/33832 to projectatomic/docker

- Description for the changelog

fixes Red Hat bz1720363.

rh-atomic-bot commented 5 years ago

Can one of the admins verify this patch? I understand the following commands:

mrunalp commented 5 years ago

LGTM

rhatdan commented 5 years ago

LGTM

robbmanes commented 5 years ago

Opened against the wrong branch entirely, shouldn't be master, should be docker-1.13.1-rhel. That one is present here: https://github.com/projectatomic/docker/pull/346