Fix stderr logging for journald and syslog

projectatomic / docker

Docker - the open-source application container engine

http://www.docker.com

Apache License 2.0

81 stars 58 forks source link

Closed robbmanes closed 5 years ago

robbmanes commented 5 years ago

logger.PutMessage, added in #28762 (v17.04.0-ce), clears msg.Source. So journald and syslog were treating stderr messages as if they were stdout.

Signed-off-by: David Glasser glasser@davidglasser.net

What I did Cherry-picked https://github.com/moby/moby/pull/28762 to projectatomic/docker via branch docker-1.13.1-rhel
Description for the changelog fixes Red Hat bz1720363.

rh-atomic-bot commented 5 years ago

Can one of the admins verify this patch? I understand the following commands:

rhatdan commented 5 years ago

LGTM

rhatdan commented 5 years ago

@mrunalp @tomsweeneyredhat PTAL

TomSweeneyRedHat commented 5 years ago

LGTM We'll need this in the 1.13.1 branch as well.

mrunalp commented 5 years ago

cc: @lsm5 for a build.

lsm5 commented 5 years ago

@rhatdan can you merge this please?

rhatdan commented 5 years ago

Done