search

projectatomic / nulecule

[UNMAINTAINED] Specification describing a container-based application
209 stars 46 forks source link

Change name for httpd container in docker provider #124

Closed bexelbie closed 9 years ago

bexelbie commented 9 years ago

helloapache isn't acceptable as it duplicates the name of the running atomicapp

jasonbrooks commented 9 years ago

Since httpd may already be a used name, is it better to leave out the --name and let docker give the container a random name? If there was a way to append some random value to the name, that might be better, or if there was a way to more randomly name the intermediate container that's causing the conflict...

bexelbie commented 9 years ago

Thinking more about it, yes 'httpd' is a bad name choice, however I feel like the application should be "labeled" when running.

Perhaps we could use - in this case: helloapache-httpd

aweiteka commented 9 years ago

No strong opinion here. LGTM

goern commented 9 years ago

from the spec point of view its just an example, for Atomic App we should thing about post-pending a uudi to the container name?

bexelbie commented 9 years ago

@goern should your comment be an issue/PR against Atomic App?

goern commented 9 years ago

I opened an issue https://github.com/projectatomic/atomicapp/issues/182 I personally would go with the first option: document a good practice and dont use any --name this will leave name generation up to docker

goern commented 9 years ago

we will leave the assignment of a name to a container up to the implementation and close this issue on the spec level