search

projectatomic / nulecule

[UNMAINTAINED] Specification describing a container-based application
209 stars 46 forks source link

Adds Gitlab Nulecule example #165

Closed navidshaikh closed 8 years ago

navidshaikh commented 8 years ago

Fixes: https://github.com/projectatomic/nulecule/issues/160

vpavlin commented 8 years ago

There are no params in any of the components although you are using them in answers and artifacts. It works because atomic app tries to be as nice to user as possible, but it's not a good practice.

Please add params to all components - I see you have $image everywhere for example. See other examples for reference: f.e. https://github.com/projectatomic/nulecule/blob/master/examples/mariadb-centos7-atomicapp/Nulecule#L11

navidshaikh commented 8 years ago

@vpavlin : ACK! thank you for the pointers. I have incorporated the review comments. Kindly review.

vpavlin commented 8 years ago

@navidshaikh I'd suggest dropping answers.conf.sample as it's auto generated on atomic install call

navidshaikh commented 8 years ago

Updated PR w.r.t suggestions and reviews. Is this okay now ?

navidshaikh commented 8 years ago

Automated build of gitlab example at https://hub.docker.com/r/swordphilic/gitlab-centos7-atomicapp/ - it can be used to test if example works.

goern commented 8 years ago

This has been moved to https://github.com/projectatomic/nulecule-library/tree/master/gitlab-centos7-atomicapp