search

projectatomic / nulecule

[UNMAINTAINED] Specification describing a container-based application
209 stars 46 forks source link

$hostport should be "$hostport" #192

Closed cdrage closed 8 years ago

cdrage commented 8 years ago

Run nulecule/examples/helloapache/artifacts/kubernetes/hello-apache-pod.json through jsonlint and you'll see that it's invalid.

One of the reasons being is that for numeric values that are filled in with a param, we do not add any quotes.

Adding quotes to this makes the json/haml valid and does not harm deployment via Kubernetes, OpenShift, etcetera, as the respective programs convert the string value regardless.

I believe, for example: $hostport should be "$hostport" within examples and such. This will allow programs such as a json to yaml converter be able to easily validate and convert such objects.

dustymabe commented 8 years ago

we need to remove the examples from this github repo. They have been moved to nulecule-library.

dustymabe commented 8 years ago

please open against nulecule-library