projectatomic / nulecule

[UNMAINTAINED] Specification describing a container-based application
209 stars 46 forks source link

Removing graph(s) in favour of app-name #210

Closed cdrage closed 8 years ago

cdrage commented 8 years ago
graph:
  - name: mariadb-centos7-atomicapp
    source: docker://projectatomic/mariadb-centos7-atomicapp

  - name: helloapache-app
    params:
      - name: image
        description: The webserver image
        default: centos/httpd
      - name: hostport
        description: The host TCP port as the external endpoint
        default: 80
    artifacts:
      docker:
        - file://artifacts/docker/hello-apache-pod_run
      kubernetes:
        - file://artifacts/kubernetes/hello-apache-pod.json
      openshift:
        - inherit:
          - kubernetes
      marathon:
        - file://artifacts/marathon/helloapache.json

to

mariadb-centos7-atomicapp:
    source: docker://projectatomic/mariadb-centos7-atomicapp

helloapache-app:
    params:
      - name: image
        description: The webserver image
        default: centos/httpd
      - name: hostport
        description: The host TCP port as the external endpoint
        default: 80
    artifacts:
      docker:
        - file://artifacts/docker/hello-apache-pod_run
      kubernetes:
        - file://artifacts/kubernetes/hello-apache-pod.json
      openshift:
        - inherit:
          - kubernetes
      marathon:
        - file://artifacts/marathon/helloapache.json
goern commented 8 years ago

any rational on this?

cdrage commented 8 years ago

Clarity and way easier to learn. Consistent with a compose style model of launching an application.

Thoughts @dustymabe ?

goern commented 8 years ago

so you encode the name of the graph as an element name, I dont know if I would put that on the 'clarity list' ;)

cdrage commented 8 years ago

@goern Are you able to clarify what you mean? Example please? :)

I know you specify -name but it's much simpler for clarity if you specify via an actual app name instead.

goern commented 8 years ago

There is no example, please see https://github.com/kubernetes/kubernetes/issues/2004 and https://github.com/projectatomic/nulecule/issues/35 why we have made the decision how to design the things as the are.