search

projectatomic / oci-systemd-hook

OCI hook to enable running systemd in a container
GNU General Public License v3.0
64 stars 26 forks source link

Allow container definitions where rootfs is not an absolute path #67

Closed jwessel closed 7 years ago

jwessel commented 7 years ago

In earlier versions of the runc frame work the rootfs path was passed as a key with the initial json that was passed on the stdin and it was automatically computed to be an absolute path.

This translation to an absolute path must be done in the hook based on the bundlePath. This allows the config.json to be relocated by the container hosting system storage without modifying the config.json.

Signed-off-by: Jason Wessel jason.wessel@windriver.com

rhatdan commented 7 years ago

LGTM @mrunalp WDYT?

TomSweeneyRedHat commented 7 years ago

LGTM, but want to hear @mrunalp 's $.02

rhatdan commented 7 years ago

Do we need the same patch for oci-umount?

mrunalp commented 7 years ago

Yes we should add it there.

On Jul 13, 2017, at 10:42 AM, Daniel J Walsh notifications@github.com wrote:

Do we need the same patch for oci-umount?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.