search

projectatomic / oci-systemd-hook

OCI hook to enable running systemd in a container
GNU General Public License v3.0
64 stars 26 forks source link

Configure via container labels? #81

Open cgwalters opened 7 years ago

cgwalters commented 7 years ago

In https://github.com/projectatomic/oci-systemd-hook/issues/76 we talked about configuration a bit.

How about supporting configuration via labels? It feels really like a terrible hack to me to strcmp() the container's argv[0]. Something like:

LABEL org.projectatomic.systemd=yes ? Then we could have: LABEL org.projectatomic.systemd.journal=persistent too?

rhatdan commented 7 years ago

I would not want to change what we have now, since it would break existing containers, but adding the second label would be fine with me.