search

projectatomic / openshift2nulecule

Create Nulecule application from OpenShift project
GNU General Public License v2.0
6 stars 9 forks source link

Use docker cli instead of docker-py library #29

Closed kadel closed 8 years ago

kadel commented 8 years ago

This is because of conflicting versions of python-docker-py Atomic that is currently in CentOS7 requires python-docker-py 1.4.0 and it is not working with new versions. OpenShift2Nulecule requires python-docker-py 1.6.0 and up and it is not working with lower versions.

Related issues: https://github.com/projectatomic/adb-atomic-developer-bundle/issues/279 https://github.com/projectatomic/openshift2nulecule/issues/21

surajssd commented 8 years ago

@kadel looks good but then we are doing the same thing what Atomic App has done to itself i.e. use Docker CLI than Docker API, but looking at the urgency of moving this thing this is the right way to go. Can't we just give a docker image of the openshift2nulecule i.e. use docker to package than rpm?

kadel commented 8 years ago

using Docker CLI is not ideal I agree and and it should be only temporary solution until packaging conflict is solved.

Using this only from container might be also possible. At this point I'm not really sure what is better :-(

surajssd commented 8 years ago

@kadel what you have done for now seems good to me!