search

projectatomic / rhel-push-plugin

Blocks RHEL content push to docker.io
GNU General Public License v2.0
7 stars 7 forks source link

prepend 'docker-' to repo name #6

Open lsm5 opened 8 years ago

lsm5 commented 8 years ago

This will make it consistent with docker-novolume-plugin and docker-lvm-plugin. Or we could remove docker- from the other two. Either way works.

runcom commented 8 years ago

I'm more in favor or removing docker- from the other but no big deal, @rhatdan wdyt?

lsm5 commented 8 years ago

yup, NBD either way, and in rpms, i'm prepending docker- to subpackages if it doesn't exist. so docker-lvm-plugin and docker-rhel-push-plugin etc.

runcom commented 8 years ago

my point is that if we talk about them as docker plugins then the docker- prefix is redundant so better take it off, but again, as you all wish .

I.E.

The docker-lvm-plugin can be just the lvm-plugin, same goes for the novolume one: docker daemon --autorization-plugin=novolume (also w/o the plugin suffix)

rhatdan commented 8 years ago

Remove them. I would like to see if in the future we could make these auth plugins able to be used by more then docker. It would be nice if we could take advantage of some via k8s running runc containers for example. Or atomic push could use them to stop pushing rhel content.