projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Document how to configure OpenShift with custom image tag, registry etc #362

Closed coolbrg closed 7 years ago

coolbrg commented 8 years ago

Hi,

It seems the documentation on configuring OpenShift with custom image tag, registry has be removed by mistake. Unable to find the doc from past five minutes in both here and ADB repo.

May be its there but its quite not visible properly.

It looks like something this mentioned in this quick start of release v1.0.0 3rd and 4th points.

coolbrg commented 8 years ago

cc @Preeticp

Preeticp commented 8 years ago

@budhrg this documentation exists in ADB usage document, in the using ADB with host based tools section, as discussed earlier.

coolbrg commented 8 years ago

Found the docs here as we decided to move it there. This will be more important in customizing OpenShift I would suggest here to make a reference of it in VSM repo. Something inside the sections like configurations etc etc and then point to this docs.

coolbrg commented 8 years ago

@bexelbie I think this feature is getting hidden in some sense since it is now not visible properly in VSM and nor in ADB README directly.

Even inside ADB, it is only mentioned in using.rst page under section "Using ADB with host-based tools (Eclipse and CLIs) # 3".

Is there any way to make such feature visible? Like we can give users all options they can try in separate docs.

Preeticp commented 8 years ago

+1 @budhrg for giving users all the options they can try. Could you please mention which options you would like to cover and the relevant details, based on that, a decision can be arrived at, as to whether we need different sections for those options within Usage doc or we need separate docs for each of the option. Also depending on what needs to be covered we may want to create a separate issue for this in ADB repo, and linking VSM repo to those docs/sections can be done at the same time.

hferentschik commented 7 years ago

@budhrg, just to be clear - you are talking about these options, right?

My first question is really whether these options are actually still working? This this functionality there? I was hoping though, since this is imo also the solution to how to use/upgrade to a newer OpenShift version w/o rebuilding/releasing the whole box (ADB/CDK). AFAIU though this is not working as intended anymore.

hferentschik commented 7 years ago

Hmm, the options are actually still in the code. No idea whether it works though under the hood in the VM. If so, these options need indeed to be documented here again.

coolbrg commented 7 years ago

Yes @hferentschik . These options works and it is there in the code. We need to document it.

hferentschik commented 7 years ago

These options works and it is there in the code.

Cool. Then I wonder why this was a no go for the case where someone wanted to use CDK 2.2 with the latest OpenShift version. This is exactly why we added this in the first place. Yes, you need an image download in this case, but that does not matter imo. @LalatenduMohanty WDYT?

We need to document it.

+1

LalatenduMohanty commented 7 years ago

@hferentschik SCCLI works behind the scene to download the new images mentioned and set it up. However we used to skip the code for CDK. So it will not work for CDK 2.2 but works for ADB. Recently we enabled it for CDK too. So any release post adb-utils version 2.0 these options will work for CDK too.

coolbrg commented 7 years ago

any release post adb-utils version 2.0 these options will work for CDK too.

:+1:

hferentschik commented 7 years ago

Fixed via pull request #437