Fix #257: proper error message on restarting a stopped service

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.

GNU General Public License v2.0

18 stars 16 forks source link

Fix #257: proper error message on restarting a stopped service #382

Closed coolbrg closed 8 years ago

coolbrg commented 8 years ago

Fix #257

Patched gem: https://www.dropbox.com/s/ytkrfc0f4ru3mma/vagrant-service-manager-1.4.0.dev.gem.

Please verify @pavanbhat21 and @amitkrout

pavanbhat21 commented 8 years ago

I tried on my fedora machine, LGTM.

coolbrg commented 8 years ago

@navidshaikh Rebased with upstream master.

coolbrg commented 8 years ago

@navidshaikh Updated as per suggestions.

navidshaikh commented 8 years ago

The right fix for the issue would be to start the kubernetes service even if it is stopped (and openshift is also stoppped as well) and user has commanded vagrant service-manager restart kubernetes, the service should start.

Lets hold till we have a decision on https://github.com/projectatomic/adb-utils/issues/157

navidshaikh commented 8 years ago

As discussed, lets get this PR in and wait for support from sccli https://github.com/projectatomic/adb-utils/issues/157 .

navidshaikh commented 8 years ago

LGTM