search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

[RFE] VSM install-cli should allow reusing existing OC, docker, kube binaries #390

Closed LalatenduMohanty closed 8 years ago

LalatenduMohanty commented 8 years ago

OS details: All supported OS

Provider: VirtualBox and/or Libvirt and/or HyperV (for CDK only)

Output of vagrant service-manager box version:

vagrant-service-manager (1.3.3)

If user has downloaded the binaries for OC, docker, kube binaries , VSM install-cli should reuse the binaries. It will be useful for CDK users as Devsuite puts a OC binary on users machine.

coolbrg commented 8 years ago

@LalatenduMohanty , install-cli has the ability to detect the binaries (oc,docker) which are present in environment variable PATH. Devsuite puts the oc binary in users machine and add its entry to PATH which install-cli can able to detect with current version.

Any other use case you are referring here?

LalatenduMohanty commented 8 years ago

@budhrg I just wanted to reuse the OC binary I had downloaded (manually) previously.

coolbrg commented 8 years ago

@LalatenduMohanty Do you mean to say if user specify --path which is already downloaded binary, then it should use that binary instead of downloading it?

LalatenduMohanty commented 8 years ago

@budhrg yes, thats my expectation.

hferentschik commented 8 years ago

I don't get how service-manager is involved here? If you download your own version of the client, it is up to you to manage its location and add it to the PATH, right?

Now, if you use install-cli with the --path option and the designated path contains the binary, I would expect service-manager to ask for conformation prior to overwriting the binary.

coolbrg commented 8 years ago

Now, if you use install-cli with the --path option and the designated path contains the binary, I would expect service-manager to ask for conformation prior to overwriting the binary.

Ya +1.

If you download your own version of the client, it is up to you to manage its location and add it to the PATH, right?

Agree. But increase usability if we give them direct export line for that binary location.

LalatenduMohanty commented 8 years ago

May be I misunderstood the --path option. I was thinking --path can be used to point to an existing OC binary.

hferentschik commented 8 years ago

I was thinking --path can be used to point to an existing OC binary.

It points out the directory to which you want to download to in case you want the binary not in the default location somewhere under the ~/.vagrant/data tree. I think this issue can actually be closed.

LalatenduMohanty commented 8 years ago

Closing the issue.