Fix #302 service-manager config options for HTTP proxy

[coolbrg]

Fix #302

[hferentschik]

What happened to testing?

[coolbrg]

@hferentschik Not sure how to add acceptance tests for this (Proxy checks)

[hferentschik]

Add unit tests

[coolbrg]

@hferentschik Added a unit test to check the functionality of method which is responsible for building proxy options for commands.

[LalatenduMohanty]

@budhrg can you please explain how will be the user experience i.e. how user is going to use proxy information with VSM? Also I do not see any documentation change for this PR?

[coolbrg]

@LalatenduMohanty The user will able to leverage this via configurations as:

config.servicemanager.http_proxy = '10.70.49.109:3128'
config.servicemanager.http_proxy_user = 'fedora'
config.servicemanager.http_proxy_password = 'xxxx'
config.servicemanager.services = 'docker, openshift'

I think documentation, we can add later on since for these configurations only I created one issue which still need to be addressed. https://github.com/projectatomic/vagrant-service-manager/issues/362

[LalatenduMohanty]

@budhrg cool. I think #362 is a different issue. You should create another issue for this.

[hferentschik]

@budhrg can you please explain how will be the user experience i.e. how user is going to use proxy information with VSM? Also I do not see any documentation change for this PR?

Very good point. The doc side of things is completely missing.

[hferentschik]

I think documentation, we can add later on since for these configurations

-1 - A new feature/fix consists of: the fix, tests and required doc changes. Why would you tackle doc changes somewhere else than here?

[coolbrg]

@hferentschik @LalatenduMohanty Issue https://github.com/projectatomic/vagrant-service-manager/issues/401 has been created to track it.

[coolbrg]

@hferentschik Added few more testcases related to proxy validations and test similar to vagrant-registration to capture command being fire.

[hferentschik]

Added few more testcases related to proxy validations and test similar to vagrant-registration to capture command being fire.

I'll take a look

[hferentschik]

Merged. Thanks