Closed coolbrg closed 7 years ago
cc @hferentschik , @LalatenduMohanty
@budhrg Any reason why you put these two things into a single commit. It would help if they were separated. If nothing else in order to distinguish which change is for which issue. Assuming that only the feature test and change to plugin.rb are relevant for the reload issue, it should be quite simple to do an interactive rebase. WDYT?
Any reason why you put these two things into a single commit.
Since the messaging part was common in both the issues, I thought better I will include in one commit. However, as you said it would be good for rebasing if given separate. Will do that.
@budhrg LGTM but you should separate the commits as @hferentschik mentioned.
@hferentschik , @LalatenduMohanty , separated the commits.
separated the commits.
thanks
Fix #406
Now, the services starts on vagrant reload too. My logs:
There is already #409 issue which is why we are getting "openshift configuration error" on vagrant reload. Ignore it.