projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Fix #406 Service hooks doesn't start in vagrant reload #410

Closed coolbrg closed 7 years ago

coolbrg commented 7 years ago

Fix #406

Now, the services starts on vagrant reload too. My logs:

$ vagrant up --provider virtualbox
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Importing base box 'cdkv2'...
==> default: Matching MAC address for NAT networking...
==> default: Setting the name of the VM: vagrant-service-manager_default_1476273881549_14627
.........
==> default: Configuring and enabling network interfaces...
==> default: Copying TLS certificates to /home/budhram/redhat/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker
==> default: Docker service configured successfully...
==> default: OpenShift service configured successfully...
==> default: Mounting SSHFS shared folder...
==> default: Mounting folder via SSHFS: /home/budhram => /home/budhram
==> default: Checking Mount..
==> default: Folder Successfully Mounted!
==> default: Running provisioner: shell...
    default: Running: inline script
==> default: 
==> default: Successfully started and provisioned VM with 2 cores and 3072 MB of memory.
........ 
==> default: Configured users are (<username>/<password>):
==> default: openshift-dev/devel
==> default: admin/admin
==> default: 
==> default: If you have the oc client library on your host, you can also login from your host.

##### Reloading ######

$ vagrant reload
==> default: Attempting graceful shutdown of VM...
==> default: Clearing any previously set forwarded ports...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
    default: Adapter 2: hostonly
==> default: Forwarding ports...
    default: 22 (guest) => 2222 (host) (adapter 1)
....
==> default: Configuring and enabling network interfaces...
==> default: Copying TLS certificates to /home/budhram/redhat/vagrant-service-manager/.vagrant/machines/default/virtualbox/docker
==> default: Mounting SSHFS shared folder...
==> default: Mounting folder via SSHFS: /home/budhram => /home/budhram
==> default: Checking Mount..
==> default: Checking Mount..
==> default: Folder Successfully Mounted!
==> default: Docker service configured successfully...
==> default: Openshift service failed to configure properly...
==> default: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> default: flag to force provisioning. Provisioners marked to run always will still run.
==> default: Running provisioner: shell...
    default: Running: inline script
.... 
==> default: You can now access the OpenShift console on: https://10.1.2.2:8443/console
==> default: 
==> default: To use OpenShift CLI, run:
==> default: $ vagrant ssh
==> default: $ oc login
....
==> default: 
==> default: If you have the oc client library on your host, you can also login from your host.

$ vagrant service-manage status docker
docker - running

$ vagrant service-manage status openshift
openshift - running

There is already #409 issue which is why we are getting "openshift configuration error" on vagrant reload. Ignore it.

coolbrg commented 7 years ago

cc @hferentschik , @LalatenduMohanty

hferentschik commented 7 years ago

@budhrg Any reason why you put these two things into a single commit. It would help if they were separated. If nothing else in order to distinguish which change is for which issue. Assuming that only the feature test and change to plugin.rb are relevant for the reload issue, it should be quite simple to do an interactive rebase. WDYT?

coolbrg commented 7 years ago

Any reason why you put these two things into a single commit.

Since the messaging part was common in both the issues, I thought better I will include in one commit. However, as you said it would be good for rebasing if given separate. Will do that.

LalatenduMohanty commented 7 years ago

@budhrg LGTM but you should separate the commits as @hferentschik mentioned.

coolbrg commented 7 years ago

@hferentschik , @LalatenduMohanty , separated the commits.

hferentschik commented 7 years ago

separated the commits.

thanks