search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Fix #409 fixes Openshift service failed message on vagrant up #411

Closed coolbrg closed 8 years ago

coolbrg commented 8 years ago

Fix #409

coolbrg commented 8 years ago

@hferentschik

So what am I looking at here? What am I looking for? This is about some startup message right? Can we not modify our existing adb_openshift.feature to check the output of 'vagrant up', verifying the unwanted output is not there and replaced by whatever is expected. We don't even have to write a new scenario, use add another step to an existing one, right?

Added testcase. Thanks

hferentschik commented 8 years ago

@budhrg actually, this pull request does not rebase cleanly. Could you rebase yourself and push an update?

coolbrg commented 8 years ago

@hferentschik Rebased and pushed :smile:

hferentschik commented 8 years ago

Merged, thanks.