Open coolbrg opened 8 years ago
then you need to specify minimum memory for VM to start openshift properly during vagrant up process.
If this is what's required, lets add it. We don't want to use the full Vagrantfile. This is about just using the minimal configuration required. It is actually imo a good thing that we find out these type of details.
So you are saying that the reason the VM did not come up (locally as well as on CI) as part of the test run was the memory setting. No explicit setting => fail, explicit setting => success?
I am wondering whether there is a difference here in whether you start as part of the Cucumber framework or from the command line. The same Vagrantfile as part of the Cucumber test does not start OpenShift. If I then, however, start just the VM (from the build/aruba directory) it would actually work. Just wondering.
@hferentschik @LalatenduMohanty I believe its a documentation issue. Any perfect place this can go which is easily visible?
cc @Preeticp
I am happy to just add a comment to the feature file. After all for ADB/CDK we have already per default higher values (correct me from wrong here).
Not sure whether there is much more we need to do in the service-manager repo, except maybe adding a note/comment.
@hferentschik Note is required for openshift specifically as we assume that vagrant init projectatomic/adb
should just work with config.servicemanager.services = 'docker'
line. This these two lines are enough for docker but for openshift we need to add minimum memory line too now.
Ok, but I guess this is a matter for a developer-bundle then where it should be documented, right?
Hi @Preeticp , I will let you to decide the appropriate place to document it.
Since it is more of service-manager specific, I thought better it will be here in this repo as a note only. Or we can keep it both.
I think it should be documented in the ADB installation guide as the issue has to do with a minimal vagrantfile and the vagrant init method of starting a vagrant box. @budhrg can you explain further why you say it is more VSM specific? IIRC, the vagrant init projectatomic/adb method was removed from the ADB installation as we wanted users to use the custom vagrantfiles provided by ADB. If the minimal vagrantfile is to be documented, then the vagrant init method will also need to be reintroduced in the docs. @LalatenduMohanty, @praveenkumar could you please clarify our stand on the vagrant init approach.
then the vagrant init method will also need to be reintroduced in the docs.
Yes, we need to get clarify it first. The thing is as a developer I prefer to have minimal vagrantfile, like if you see our tests contains minimal Vagrantfile where I found that minimum memory need to be specified.
I would vote for having a separate section for minimal Vagrantfile approach as we are using it in our test suite.
I would vote for having a separate section for minimal Vagrantfile approach as we are using it in our test suite.
I would say not to have any more documentation around it because in our standard documentation which talks about how to get started with ADB/CDK have precious instructions about using specific Vagrantfile for specific case. My understanding is if we create another doc saying that a user can also use minimal Vagrantfile which also need VSM specific edit (like config.servicemanager.services = "docker, openshift"
) then it will confuse user plus it will make debugging also little hard if someone hit a issue.
Note: Only around VSM because we are using it for CI then just put it in VSM doc so we can reference it but not ADB overall.
@LalatenduMohanty @hferentschik WDYT?
TBH, I don't think we really need to do anything here. At least not in vagrant-service-manager. If anything I add a comment to the Cucumber feature file.
Hi,
It seems that if you don't want to use [recommended Vagrantfiles from ADB](), then you need to specify minimum memory for VM to start openshift properly during
vagrant up
process.Steps to Reproduce
vagrant up
Memory inside VM during Openshift provisioning
Vagrant debug logs