search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Improving output of Cucumber tests and re-organizing feature files #426

Closed hferentschik closed 7 years ago

hferentschik commented 7 years ago

Addresses issue #419 and #425

hferentschik commented 7 years ago

@LalatenduMohanty, @budhrg - new pull request. Commits are split now across two issues as discussed. Commit 692c is still separate, since it technically is not a cleanup, but I rather disable a test due to the OpenShift issue.

hferentschik commented 7 years ago

@budhrg pushed an update

LalatenduMohanty commented 7 years ago

@hferentschik @budhrg LGTM.

coolbrg commented 7 years ago

@hferentschik Let me know if you are adding systemctl start openshift changes here and CI is passing, Locally it is passing but not CI for me. details here https://github.com/projectatomic/vagrant-service-manager/issues/415#issuecomment-256048733

hferentschik commented 7 years ago

Let me know if you are adding systemctl start openshift changes here and CI is passing, Locally it is passing but not CI

Hmm, I would have thought that would be a new pull request for issue #415

coolbrg commented 7 years ago

Hmm, I would have thought that would be a new pull request for issue #415

Cool. Will merge this now.

coolbrg commented 7 years ago

Merged and thanks.