search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Issue #346 Adding a Rake task for Asciidoctor #436

Closed hferentschik closed 8 years ago

hferentschik commented 8 years ago

and enabling Guard and Live Reload

Addresses issue #346

hferentschik commented 8 years ago

@budhrg did you have a chance to try this. I'd like to merge this asap

coolbrg commented 8 years ago

@hferentschik It is not working efficiently for me. I need to reload the page to get updated content.

hferentschik commented 8 years ago

It is not working efficiently for me. I need to reload the page to get updated content.

What the pull request is about, is the ability to rebuild on each change. A automatic reload via "LiveReload" is just the icing on the cake. Whether it will work will depend on your browser and plugin version. Do you have "LiveReload" installed? Do you see that Guard reports that the browser is connected?

hferentschik commented 8 years ago

@budhrg I pushed an update with the typo fixes

coolbrg commented 8 years ago

@hferentschik Here is the log,

➜  vagrant-service-manager git:(hardy-fix-346) ✗ bundle exec guard
17:49:13 - INFO - Starting guard-rake html
17:49:13 - INFO - running html
asciidoctor: WARNING: README.adoc: line 51: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 60: list item index: expected 3, got 1
asciidoctor: WARNING: README.adoc: line 71: list item index: expected 4, got 1
asciidoctor: WARNING: README.adoc: line 187: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 193: list item index: expected 3, got 1

17:49:13 - INFO - LiveReload is waiting for a browser to connect.
17:49:13 - INFO - Guard is now watching at '/home/budhram/redhat/vagrant-service-manager'
[1] guard(main)> 
17:49:17 - INFO - Run all
17:49:17 - INFO - running html
asciidoctor: WARNING: README.adoc: line 51: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 60: list item index: expected 3, got 1
asciidoctor: WARNING: README.adoc: line 71: list item index: expected 4, got 1
asciidoctor: WARNING: README.adoc: line 187: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 193: list item index: expected 3, got 1

[1] guard(main)> 
17:49:18 - INFO - Run all
17:49:18 - INFO - running html
asciidoctor: WARNING: README.adoc: line 51: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 60: list item index: expected 3, got 1
asciidoctor: WARNING: README.adoc: line 71: list item index: expected 4, got 1
asciidoctor: WARNING: README.adoc: line 187: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 193: list item index: expected 3, got 1

17:49:18 - INFO - Reloading browser: build/html/CHANGELOG.html build/html/CONTRIBUTING.html build/html/README.html build/html/commands.html
17:49:18 - INFO - Reloading browser: build/html/CHANGELOG.html build/html/CONTRIBUTING.html build/html/README.html build/html/commands.html
17:49:32 - INFO - running html
asciidoctor: WARNING: README.adoc: line 51: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 60: list item index: expected 3, got 1
asciidoctor: WARNING: README.adoc: line 71: list item index: expected 4, got 1
asciidoctor: WARNING: README.adoc: line 187: list item index: expected 2, got 1
asciidoctor: WARNING: README.adoc: line 193: list item index: expected 3, got 1

17:49:33 - INFO - Reloading browser: build/html/CHANGELOG.html build/html/CONTRIBUTING.html build/html/README.html build/html/commands.html
hferentschik commented 8 years ago

Here is the log,

So what's the issue? Are you talking about the Warnings? It seems to rebuild on changes, right and it even seems to be connected to the browser. So what is the problem?

coolbrg commented 8 years ago

So what is the problem?

It seems that rebuilding this is working fine. The issue is only with live-reload which is not working properly for me. I need to reload the browser to see the updated changes.

hferentschik commented 8 years ago

It seems that rebuilding this is working fine. The issue is only with live-reload which is not working properly for me. I need to reload the browser to see the updated changes.

Do you have the plugin installed? Does it connect to Guard? Do you enable it for the page you are viewing?

coolbrg commented 8 years ago

LGTM :+1: