Closed NBau closed 5 years ago
Can you make the code available to me?
Yes, sure, but first I would like to get the tests to pass and do some more quality checks. This is the reason for this issue; some tests were failing or causing errors even before my modifications, which makes it quite difficult for me to make sure I did not break anything.
Since the build is passing the tests must pass prior to code changes ... Is BarbelHistoCore_MultiUpdate_andQuery_SuiteTest the only test suite that causes errors?
I tried again, just downloaded the master branch and ran the tests, same fails and errors as above . The travis build seems to be configured to skip tests (-DskipTests=true), so having a passing build might not be a good indication of successfull tests. Does it work locally for you?
Making barbelhisto LocalDateTime aware isn't a small todo ...
Please get the tests running first.
It's difficult for me to setup your environment remotely ... wish I could help you more here. Appreciate your engagament though.
It seems to be a windows problem, I managed to run the tests on a linux machine just fine. Thank you for your help. If you think it is helpful for others, you could add a disclaimer somewhere explaining that the tests might fail in windows. It seems to be related to file access (some files not yet closed when trying to delete them or something similar).
Thanks for the update. Will you make a pull request when you finish your work?
BTW: Tests have always been part of the travis build; it's just not so obvious in the build log. Open the "paragraphs" in the build log to find all the unit test results.
Hello, First of all, thank you for providing this library. I was trying to implement a patch to support LocalDateTime instead of LocalDate (I have the same problem as mentioned in #4), but I noticed that after my changes some tests were producing errors and some tests were failing. When running
mvn clean install
on the unmodified master branch, I noticed a similar behaviour. In particular, the following output is created:Am I doing something wrong?