search

projectblacklight / arclight

A Rails engine supporting discovery of archival material
https://samvera.atlassian.net/wiki/spaces/samvera/pages/405211890/ArcLight
Other
39 stars 25 forks source link

Sort collections by title on repository page #1522

Closed taylor-steve closed 5 months ago

taylor-steve commented 7 months ago

While looking at https://github.com/sul-dlss/stanford-arclight/issues/429 we have been looking at how the repository page is sorted by default.

What do folks think about sorting that page using the default title sort field? I think it improves that page, but I'd also understand not wanting to tie it to specific configuration.

marlo-longley commented 7 months ago

Thanks for adding this @taylor-steve. My instinct is for any config to take an approach that is configurable for implementers, potentially even per repository.

In our local Stanford instance, we recently added a different way of setting config (See https://github.com/sul-dlss/stanford-arclight/pull/466/files#diff-8d22082941b3ca9f588bb2b795ae8f86f233c0175d799a8703dad41458087832) that provides a settings.yml file. But there is no such place for overall settings in the Arclight Core codebase, which I think makes sense in theory not to impose on implementers.

In Core, we do have the repositories.yml file. That file contains values that are directly displayed such as description etc. I do think a case could be made for reading a sort value in this file, though, since it is display-related if not directly displayed. Maybe we could provide this default as you suggest, but override it if a value is provided per repository, leaving that option for implementers. Just thinking out loud, though...

taylor-steve commented 5 months ago

Thanks @marlo-longley. I'm going to close this for now and will re-open with a different PR if we pursue this work further.