search

projectblacklight / blacklight-access_controls

Provides access controls for Blacklight-based Rails applications.
2 stars 3 forks source link

Simplify terms query #19

Open awead opened 8 years ago

awead commented 8 years ago

Instead of: ({!terms f=discover_access_group_ssim}public) OR ({!terms f=read_access_group_ssim}public) do something like: ({!terms f=discover_access_group_ssim v=$groups}) OR ({!terms f=read_access_group_ssim v=$groups})&groups=public

kudos to @erikhatcher for pointing this out in #17

atz commented 8 years ago

Interesting. Wouldn't call this simplification, though. In particular because we need the clauses to be atomic since they are aggregated and crudely OR'd together.

erikhatcher commented 8 years ago

Wouldn't call this simplification, however.

It's DRYer though :)