search

projectblacklight / blacklight-gallery

Gallery views for Blacklight
Other
14 stars 11 forks source link

Off by one error in blacklight gallery slideshow #2567 #157

Closed dnoneill closed 2 months ago

dnoneill commented 2 months ago

Example: https://exhibits.stanford.edu/bacon/catalog?q=&search_field=search&view=slideshow Clicking on the first result in the slideshow opens the second, and so on.

This seems related to whether version 2 or 3 of view_component is being used.

See: https://github.com/search?q=repo%3Aprojectblacklight%2Fblacklight%20COLLECTION_INDEX_OFFSET&type=code https://github.com/projectblacklight/blacklight-gallery/commit/03721c40297be61babf4190d16a591f66dc7e7c2#diff-2014cfde3b1fa7bf929fade26c45c1a9a4328199617a56400c85b806e21f3964R7

Updating exhibits to view_component v3 should fix this (https://github.com/sul-dlss/exhibits/issues/2563), but any app still using v2 is impacted.

dnoneill commented 2 months ago

I maybe reading blacklight-gallery wrong but I think this is going to be a problem no matter what view_component version you are using.