search

projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.
http://projectblacklight.org/
Other
757 stars 257 forks source link

CI lint step is failing #3062

Closed sandbergja closed 1 year ago

sandbergja commented 1 year ago

Output from CI:

Running RuboCop...
RuboCop failed!
Inspecting 347 files
..................................................................................................................................................................................C..............................................................................................C.........................................................................

Offenses:

lib/blacklight/solr/response/group_response.rb:54:22: C: [Correctable] Style/ArgumentsForwarding: Use shorthand syntax ... for arguments forwarding.
  def method_missing meth, *args, &block
                     ^^^^^^^^^^^^^^^^^^^
lib/blacklight/solr/response/group_response.rb:56:21: C: [Correctable] Style/ArgumentsForwarding: Use shorthand syntax ... for arguments forwarding.
      response.send(meth, *args, &block)
                    ^^^^^^^^^^^^^^^^^^^
spec/models/blacklight/configurable_spec.rb:96:51: C: [Correctable] Layout/ExtraSpacing: Unnecessary spacing detected.
      expect(instance.blacklight_config.foo).to eq  "bar"
                                                  ^
spec/models/blacklight/configurable_spec.rb:96:51: C: [Correctable] Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.
      expect(instance.blacklight_config.foo).to eq  "bar"

It looks like a new feature in Rubocop 1.55.0 and a bug fix in 1.54.2 are to blame.