Two fields in the advanced search form are missing labels - Githubissues

projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.

http://projectblacklight.org/

Other

757 stars 256 forks source link

Two fields in the advanced search form are missing labels #3072

Closed sandbergja closed 11 months ago

sandbergja commented 11 months ago

Steps to recreate

In Firefox:

Go to https://demo.projectblacklight.org/catalog/advanced
Right click on the "all" dropdown in the sentence "Match all of the fields below".
Select "Inspect Accessibility Properties"
Note that the name is "null", and that you get an alert "Form elements must be labeled". Expected behavior is that the form element does have an accessible name.
Repeat steps 2-4 on the "relevance" sort dropdown at the end of the form.

Suggested fixes

Add an aria-label to the first dropdown
Associate the "relevance" dropdown with the "Sort results by" label, perhaps using aria-labelledby.

sandbergja commented 11 months ago

Just realized that @cbeer already fixed these in #3068. Closing this issue.