search

projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.
http://projectblacklight.org/
Other
757 stars 255 forks source link

Add missing rubocop gems and auto-update #3193

Closed jcoyne closed 3 weeks ago

jrochkind commented 3 weeks ago

Any idea what made be_a_kind_of, that apparently previously worked, stop working and have to be changed to be_a?

(The mystery might be why be_a_kind_of ever worked! The correct method name, that I think still would be working as a synonum to be_a, is be_kind_of (no _a_))

jcoyne commented 3 weeks ago

@jrochkind I think it's just a matter of preference. https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecclasscheck is the rule

mjgiarlo commented 3 weeks ago

@jrochkind 💬

Any idea what made be_a_kind_of, that apparently previously worked, stop working and have to be changed to be_a?

(The mystery might be why be_a_kind_of ever worked! The correct method name, that I think still would be working as a synonum to be_a, is be_kind_of (no _a_))

RSpec allows a bunch of different forms: https://github.com/rspec/rspec-expectations/blob/main/lib/rspec/matchers.rb#L372-L382

jrochkind commented 3 weeks ago

Ah, so it had to be changed in this PR becuase you enabled a rubocop rule that forced it to be changed? Okeydoke!