search

projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.
http://projectblacklight.org/
Other
760 stars 256 forks source link

Arrange HTML so that the search bar is part of the main element #3398

Open jcoyne opened 1 month ago

jcoyne commented 1 month ago

Fixes #3252

cbeer commented 1 month ago

I'm not sure I understand the motivation for this change, but this seems like it could be incredibly disruptive to downstream applications are require a lot more overriding to recreate fairly common layout patterns:

Screenshot 2024-10-24 at 10 41 09

Screenshot 2024-10-24 at 10 41 24

Screenshot 2024-10-24 at 10 42 11

Screenshot 2024-10-24 at 10 42 56

jcoyne commented 1 month ago

I agree that this may be a challenge for adopters to take on. I believe this provides better semantics for accessibility. I believe this was raised by Darcy when looking at Geoblacklight (see #3252).

While implementing this it felt like our existing layouts (with content_for) made this a challenge to implement easily.