search

projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.
http://projectblacklight.org/
Other
760 stars 256 forks source link

Use a labeled <aside> for show tools sidebar #3423

Closed thatbudakguy closed 3 weeks ago

thatbudakguy commented 3 weeks ago

The show page sidebar is currently displayed inside a <section>; this changes it to use the <aside> element, which is arguably more appropriate for a sidebar.

The search sidebar had an aria-label already set, but the show sidebar did not, which also meant that it had no accessible name despite having a landmark role.

Thus this also adds a configurable aria-label for the show page sidebar similar to the one for the search sidebar.

jcoyne commented 3 weeks ago

I don't think it actually fits the aside definition:

The complementary landmark role is used to designate a supporting section that relates to the main content, yet can stand alone when separated.

I don't think the facets can stand alone, they must be displayed in context of the search results.

thatbudakguy commented 3 weeks ago

I don't think the facets can stand alone, they must be displayed in context of the search results.

Is this also true of the show tools/show page sidebar, do you think? Or just search facets?

jcoyne commented 3 weeks ago

@thatbudakguy I think the tools and show could arguably be an aside.

thatbudakguy commented 3 weeks ago

Updated to only change the show page sidebar.