search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

SavedSearchesController and Blacklight::SavedSearches should be removed. #105

Open ewlarson opened 4 years ago

ewlarson commented 4 years ago

I'm using this gem on a couple GeoBlacklight 2+ / Blacklight 7+ installs. The gem's generator adds a saved_searches_controller.rb file referencing Blacklight::SavedSearches: https://github.com/projectblacklight/blacklight_advanced_search/blob/master/lib/generators/blacklight_advanced_search/templates/saved_searches_controller.rb

I believe Blacklight::SavedSearches was removed in BL 7... so for this gem to run correctly, you have to delete the saved_searches_controller.rb file the generator creates like so: https://github.com/psu-libraries/psulib_blacklight/pull/237

Hope this helps someone!

cbeer commented 4 years ago

That sounds likely; do you want to make a PR to remove it from here?

ewlarson commented 4 years ago

I'm busy on a GeoBlacklight consulting gig at the moment, but when I find some extra time I'll cook one up. Unless someone beats me to it...