search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

Allow empty parens in a string to be safely parsed #112

Closed bibliotechy closed 1 year ago

bibliotechy commented 3 years ago

This change allows an empty set of parens, (), to be in a string and to be parsed as a token. Prior to this change, and empty set of parens would be parsed as a list with no contents which could not be successfully parsed, but instead results in a error as described in #101.

This change fixes issue #101.

bibliotechy commented 3 years ago

Failures are related to wrong node version (which I have fixed in this PR) and what look like changes in upstream Blacklight handling of facet constraints rendering. Going to try to come back to that issue later

bibliotechy commented 3 years ago

~Blocked by fixes included in https://github.com/projectblacklight/blacklight_advanced_search/pull/113~

bibliotechy commented 3 years ago

Rebased on top of fixes introduced in #113, so this is now good to go.

dkinzer commented 1 year ago

I think I should have rebased this first before merging it. I'm going to revert and then create a new PR with a rebased version because it looks like there are some issues with the HEAD of the main branch.

dkinzer commented 1 year ago

Hey @bibliotechy sorry for the mess up here. I was recently given commit access to this repo and I though I would merge this PR but I messed up and didn't rebase it before hand. It failed on the main branch so I quickly reverted main back to it's original state. I recreated your PR here at #122 and I have rebased it.