search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
25 stars 25 forks source link

Some hygeine so Travis tests can pass #113

Closed bibliotechy closed 4 years ago

bibliotechy commented 4 years ago

Currently, running the tests on master on Travis for this gem fail with two distinct errors:

  1. ActionView::Template::Error: Autoprefixer doesn’t support Node v8.12.0. Update it. - 9 tests fail with this issue.
  2. NoMethodError: undefined method 'search_state_class' for #<ActionView::TestCase::TestController:0x00000000094b15a0> - 2 tests fail with this issue.

Additionally, there are some warnings about gems being found in multiple sources:

Warning: the gem 'bindex' was found in multiple sources.
Installed from: https://rubygems.org/
Also found in:
  * http://rubygems.org/
You should add a source requirement to restrict this gem to your preferred source.

This PR fixes those errors by:

1) Updating the TRavis config to use Node 12 2) Updating the render_constraints_override spec to work with with changes introuced in Blacklight 7.8.0, by commmit https://github.com/projectblacklight/blacklight/commit/c11db267465a63f9ba91798369750466cbac0be7

It eliminates the multiple source gem warnings by updating updating the rubygems url to https.

bibliotechy commented 4 years ago

One of the three builds failed because SolrWrapper timed out on download. Could someone with travis permissions try re-running this build? https://travis-ci.org/github/projectblacklight/blacklight_advanced_search/jobs/729714069