projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

Duplicate constraints rendering #127

Open ewlarson opened 1 year ago

ewlarson commented 1 year ago

Working on a new GeoBlacklight install for UW-Milwaukee. We're seeing advanced search constraint selections rendered twice in the application:

adv_search_bug

I haven't made a lot of customizations here, beyond branding/theming, so the application is pretty vanilla:

Codebase is here: https://github.com/UWM-Libraries/GeoDiscovery/tree/feature/advanced-search

Looks like the BTAA Geoportal also has a similar issue, although there only the constraints render twice, and things are not duplicated in the facets.

Screenshot 2023-02-17 at 4 16 53 PM

I'll dive into the issue further during the GBL Winter community sprint the week of Feb. 27th, but would appreciate any insights beforehand if this rings a bell for anyone.

ewlarson commented 1 year ago

A vanilla BL v7.33.1 install displays this issue, too.

Screenshot 2023-03-03 at 9 00 49 AM
ewlarson commented 1 year ago

Forked the gem to work on a fix. Removed a lot of override code and most of the _facet_limit.html.erb view to make things right again: https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix

Screenshot 2023-03-03 at 9 58 42 AM
ewlarson commented 1 year ago

Okay! This branch is a good PR candidate: https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix-gentle-hands

I don't have write access to this repo. Can someone cut a release-7.0 branch that I can pull against?