projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
25 stars 25 forks source link

Add the add_advanced_parse_q_to_solr method to BlacklightAdvancedSearch::AdvancedSearchBuilder #35

Closed awead closed 9 years ago

awead commented 9 years ago

This paves the way for Blacklight 6.0 compatibility and gets rid of the deprecation warnings that one would see if they're including ParseBasicQ in their controllers. Using Blacklight's SearchBuilder class, you can define your own search builder, include the AdvancedSearchBuilder module, and then add add_advanced_parse_q_to_solr to search_params_logic.

mjgiarlo commented 9 years ago

:+1:

carolyncole commented 9 years ago

:+1:

cbeer commented 9 years ago

How does this fit with BlacklightAdvancedSearch::ParseBasicQ? Should one implementation depend on the other?

awead commented 9 years ago

@cbeer it doesn't. They're separate implementations. I've left BlacklightAdvancedSearch::ParseBasicQ to keep things currently working, and folks can move to the new way of including add_advanced_parse_q_to_solr to their search builder. Once Blacklight 6 is released, we can remove the ParseBasicQ module entirely.

awead commented 9 years ago

@cbeer I've updated the PR with a deprecation message that tells folks to use AdvancedSearchBuilder.add_advanced_parse_q_to_solr if they use BlacklightAdvancedSearch::ParseBasicQ.add_advanced_parse_q_to_solr