search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

Test suite uses anti-pattern #57

Open atz opened 8 years ago

atz commented 8 years ago

Invocations like:

describe "whatever" do 
   include BlacklightAdvancedSearch::FilterParser
...

are failing to properly encapsulate the inclusion. Injecting everything into the rspec example is messy. Also the appearance of affecting only that describe block is misleading.