search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

Allows bundler to find the latest 7.x release from Blacklight #95

Closed cdmo closed 5 years ago

cdmo commented 5 years ago

With how the dependency is written in master, bundler complains:

➜  psulib_blacklight git:(#46-Advanced-Search) bundle install
Fetching https://github.com/projectblacklight/blacklight_advanced_search.git
Fetching gem metadata from https://rubygems.org/........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "blacklight":
  In snapshot (Gemfile.lock):
    blacklight (= 7.0.0.rc2)

  In Gemfile:
    blacklight (>= 7.0.0.rc2)

    blacklight-marc (>= 7.0.0.rc1) was resolved to 7.0.0.rc1, which depends on
      blacklight (< 8.a, > 7.0.0.a)

    blacklight_advanced_search was resolved to 7.0.0.alpha, which depends on
      blacklight (~> 7.0)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

I copied how blacklight-marc wrote the dependency with blacklight in their gemspec.

cbeer commented 5 years ago

It sounds like updating your blacklight gem to the final 7.0.0 release would also fix the issue?

cdmo commented 5 years ago

D'oh! Yes, yes it does. Thanks. This PR is probably not needed then.