projectblacklight / blacklight_range_limit

Range facet/limit/profile plugin for Blacklight
http://github.com/projectblacklight/blacklight_range_limit
Other
20 stars 40 forks source link

asset generator fails on Blacklight 8 #210

Open jcoyne opened 1 year ago

jcoyne commented 1 year ago
    generate  blacklight_range_limit:assets
       rails  generate blacklight_range_limit:assets
      insert  app/assets/stylesheets/application.css
The file /Users/jcoyne85/workspace/projectblacklight/arclight/.internal_test_app/app/assets/javascripts/application.js does not appear to exist

https://github.com/projectblacklight/blacklight_range_limit/blob/main/lib/generators/blacklight_range_limit/assets_generator.rb#L35-L43

This probably happens if the app is not using sprockets for javascript (importmap-rails).

jrochkind commented 1 year ago

"bootstrap 8" -- I think is not a thing. Did you mean Blacklight 8.x? Off the current git head? With Rails... 7.something? A bit more fleshed out reproduction instructions might be helpful if possible!

jcoyne commented 1 year ago

Yes, this is blacklight as installed from git:

gem 'blacklight', github: 'projectblacklight/blacklight'
jrochkind commented 1 year ago

Thanks! Should the title of this issue say "Blacklight 8" instead of "bootstrap 8"? Your reproduction was with rails 7?

jcoyne commented 1 year ago

@jrochkind Yes. I updated. Thanks for catching my typo.