search

projectblacklight / blacklight_range_limit

Range facet/limit/profile plugin for Blacklight
http://github.com/projectblacklight/blacklight_range_limit
Other
20 stars 41 forks source link

Blacklight.modal is undefined when using Blacklight 8 #231

Open jcoyne opened 1 year ago

jcoyne commented 1 year ago

https://github.com/projectblacklight/blacklight_range_limit/blob/567ffafa31142b5d5980791c234b40e2519579a3/app/assets/javascripts/blacklight_range_limit/range_limit_slider.js#L9

https://github.com/projectblacklight/blacklight_range_limit/blob/567ffafa31142b5d5980791c234b40e2519579a3/app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js#L35

It should use Blacklight.Modal.modalSelector instead

saffeullah commented 6 months ago

On the project I am working, we have blacklight (8.0.0) and blacklight_range_limit (8.3.0). The issue is that blacklight range plugin doesnt seem to work. Is there any fix? image

jcoyne commented 6 months ago

@saffeullah blacklight_range_limit is not compatible with Blacklight 8.

saffeullah commented 6 months ago

@saffeullah blacklight_range_limit is not compatible with Blacklight 8.

Thanks for replying. Is there any temporary fix? Or some other way(other plugin) to get the same functionality?

jcoyne commented 6 months ago

I just don't think that anyone has done the work to make this compatible yet.