I do not understand the extra_facet_fields conditional mocking for Blacklight 8 thing, don't understand what's going on. So don't love that I have no idea how I would have done this without jcoyne, or how to write similar tests in the future.
But am super grateful to @jcoyne for getting us to green, AND with viewcomponent 3 support! I was totally blocked on that and don't think I would have been able to figure it out literally ever.
I am going to go ahead and approve/merge this despite not totally following it, glad to be moving forward.
Note (Cc @barmintor ) as a result of #241, we are now only testing on BL7, even though the gem still allows BL8, for those who have been using it all along on BL8 despite it never passing tests on BL8.
I do not understand the
extra_facet_fieldsconditional mocking for Blacklight 8 thing, don't understand what's going on. So don't love that I have no idea how I would have done this without jcoyne, or how to write similar tests in the future.But am super grateful to @jcoyne for getting us to green, AND with viewcomponent 3 support! I was totally blocked on that and don't think I would have been able to figure it out literally ever.
I am going to go ahead and approve/merge this despite not totally following it, glad to be moving forward.
Note (Cc @barmintor ) as a result of #241, we are now only testing on BL7, even though the gem still allows BL8, for those who have been using it all along on BL8 despite it never passing tests on BL8.