search

projectblacklight / blacklight_range_limit

Range facet/limit/profile plugin for Blacklight
http://github.com/projectblacklight/blacklight_range_limit
Other
20 stars 40 forks source link

Sprockets require vs. SCSS @import #55

Open atz opened 7 years ago

atz commented 7 years ago

https://github.com/rails/sass-rails#important-note

Sprockets provides some directives that are placed inside of comments called require, require_tree, and require_self. DO NOT USE THEM IN YOUR SASS/SCSS FILES. They are very primitive and do not work well with Sass files. Instead, use Sass's native @import directive which sass-rails has customized to integrate with the conventions of your Rails projects.

The blacklight_range_limit generator will insert require statements in SCSS files. Apparently, this is to be avoided.

cbeer commented 7 years ago

👍 I think we've fixed this in blacklight, and it would be great if we fixed this everywhere.