search

projectblacklight / spotlight

Spotlight enables librarians, curators, and others who are responsible for digital collections to create attractive, feature-rich websites that highlight these collections.
Other
161 stars 65 forks source link

Thumbnails on admin dashboard have too much space #2339

Closed jkeck closed 4 years ago

jkeck commented 4 years ago

This might also exist elsewhere around the app.

Screen Shot 2019-12-11 at 2 18 13 PM
ggeisler commented 4 years ago

Yeah, there are a lot of BS4-upgrade styling issues on the admin side. I've been holding off ticketing/fixing them until we get the DLME work cycle done, but am planning to work on those at some point (not that you and others shouldn't ticket them in the meantime).

mejackreed commented 4 years ago

I wonder if this particular issue is now fixed. I wasn't able to recreate it

Screen Shot 2019-12-13 at 3 18 05 PM
jkeck commented 4 years ago

Odd. This is what I see on a master locally:

Screen Shot 2019-12-13 at 6 17 20 PM

And DLME, which is running on master has:

Screen Shot 2019-12-13 at 6 18 07 PM
jkeck commented 4 years ago

@mejackreed I think the reason you may have been seeing something different is that this may be browser specific and probably has something to do with how the 4.0 flex style column widths play with table elements. The Bootstrap documentation doesn't mention sizing columns, but this generally seems to work out (and should be more consistent across browsers)